This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Don't show 0 balance when not Unlocked #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. We should probably do this in siac as well |
| @@ -81,6 +80,8 @@ IPC.on('wallet-update', function(err, result) { | |||
| } else { | |||
| updateField(err, 'Locked', '', 'lock'); | |||
| } | |||
|
|
|||
| updateField(err, 'Balance: ', unlocked ? bal : '---', 'balance'); | |||
There was a problem hiding this comment.
This should go up near where bal is initialized. Further, the whole function does nothing when result === null so a
if (!result) {
return;
}
at the top would make the code less verbose and more readable.
There was a problem hiding this comment.
The balance field is dependent upon the unlock state so it had to be moved below it, I just brought the bal initialization down next to it so they're together.
result === null adjustment has also been made.
|
Didn't 75955d0 address this? I don't see a balance at all when the wallet is locked. |
|
75955d0 only modified the Wallet plugin, this pull is for the Overview plugin. |
|
ah, gotcha |
DavidVorick
added a commit
that referenced
this pull request
Oct 16, 2015
Don't show 0 balance when not Unlocked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By showing hyphens rather than a 0 it should put some minds at ease rather than assuming all coins are lost.