This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Support allowance canceling #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechampine
force-pushed
the
cancel-allowance
branch
from
ed722e0
to
f69374a
Compare
DavidVorick
reviewed
Jan 10, 2017
|
|
||
| // Create a file. | ||
| path := filepath.Join(st.dir, "test.dat") | ||
| err = createRandFile(path, 1024) |
There was a problem hiding this comment.
needs to be a lot bigger if you want to check that uploads are being interrupted I think.
There was a problem hiding this comment.
oh seems that you don't check it was interrupted
|
Guess we need to try this in the UI now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allowance can now be canceled via
SetAllowance(Allowance{}). Doing so will cause all active contracts to be immediately archived. Archived contracts cannot be used to create Editors or Downloaders, and they are not renewed. And since the new value ofallowance.Hostsis 0, the contractor will not attempt to form any new contracts.Supporting this change in the API required relaxing the restrictions on
requiredHostsandrequiredRenewWindow.An important consideration here is that
SetAllowance(Allowance{})must invalidate all active editors and downloaders before archiving contracts and returning. Otherwise, an editor could save its updated contract toc.contractsafter the previous version had been archived.The test could be more comprehensive. It might be good enough to monitor the
Unspentmetric.