This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
protect daemon calls if explorer is built #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a dirty hack that protects the daemon calls from being exposed if there is an explorer, that allows the API to be exposed to the web without needing to worry about someone hitting the `/daemon/stop` button. The protection is only in place when there is no wallet.
|
What about the gateway? Don't want to allow people to remove all the gateway's peers, or add their own malicious nodes |
|
I threw together a proof-of-concept for a separate explorer binary. Took <30min. I think it's worth considering. |
|
Might be worth doing. I'm still in favor of the two binaries being combined, I feel weird about having two daemons. But maybe it's merited. They do different enough things are are used in sufficiently different concepts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dirty hack that protects the daemon calls from being exposed if there is an explorer, that allows the API to be exposed to the web without needing to worry about someone hitting the
/daemon/stopbutton.The protection is only in place when there is no wallet.