Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Modify template #66

Closed
snipem opened this issue Jan 7, 2022 · 7 comments
Closed

Feature Request: Modify template #66

snipem opened this issue Jan 7, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@snipem
Copy link

snipem commented Jan 7, 2022

Is there an option to disable the grey boxed meta data?

image

Otherwise, great work. I was maintaining my own fork of "feeds2imap-go" for the past years but it stopped working and the IMAP functionality was very spotty. Is it related in any way? I added readability support for non-full feeds, which would be nice in your work too.

@Necoro
Copy link
Owner

Necoro commented Jan 7, 2022

Hah, never knew about feeds2imap-go. Well, there are only so many possible names ;).

I think, adding an option for disabling the grey boxes is somewhat strange. I'd prefer to allow specifying one's own template.
Until I've added such a feature, do not hesitate to just patch internal/feed/template/html.tpl

I added readability support for non-full feeds

What do you mean by that?

which would be nice in your work too.

I'll take pull requests :)

@Necoro Necoro changed the title Feature Request: Disable Feed, Item, Files Metadata Feature Request: Modify template Jan 7, 2022
@Necoro Necoro added the enhancement New feature or request label Jan 7, 2022
@snipem
Copy link
Author

snipem commented Jan 7, 2022

See this for readability: https://github.com/go-shiori/go-readability

It scrapes a website for value content only and removes all the clutter. This can be used in some instances to turn a feed with preview content only into a full feed.

@Necoro
Copy link
Owner

Necoro commented Jan 7, 2022

See this for readability: https://github.com/go-shiori/go-readability

It scrapes a website for value content only and removes all the clutter. This can be used in some instances to turn a feed with preview content only into a full feed.

I opened a separate request for that: #67

@snipem
Copy link
Author

snipem commented Jan 8, 2022

It would be nice to change the template without recompiling and forking.

@Necoro
Copy link
Owner

Necoro commented Jan 8, 2022

That is the target, eventually. Changing the compiled template in a fork is an intermediate quick solution until that feature has been implemented :)

Implementation should not be that hard, but I'm pretty sure I won't have the time this weekend.

@snipem
Copy link
Author

snipem commented Jan 8, 2022

No hurry, if I ever change something to the code I will do a push request. Templates is of no priority to me. I will look into the tool if it is working as expected in the mean time.

Schönes Wochenende!

@Necoro Necoro self-assigned this Jan 8, 2022
Necoro added a commit that referenced this issue Jan 9, 2022
Necoro added a commit that referenced this issue Jan 9, 2022
@Necoro
Copy link
Owner

Necoro commented Jan 9, 2022

Implemented

@Necoro Necoro closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants