Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Postal Code is optional #183

Merged
merged 2 commits into from Dec 4, 2023
Merged

Fix Postal Code is optional #183

merged 2 commits into from Dec 4, 2023

Conversation

Nef10
Copy link
Owner

@Nef10 Nef10 commented Dec 4, 2023

Some countries do not use postal codes, so the field is actually optional

Some countries do not use postal codes, so the field is actually optional
@Nef10 Nef10 added bug Something isn't working major This change should bump the major version of the next release labels Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Coverage after merging postal-code into main

9.25%

Coverage Report
FileStmtsFuncsLinesUncovered Lines
Sources/RogersBankDownloader
   DownloadError.swift94.12%100%93.75%33
   RogersAccount.swift0%0%0%101–105, 107–111, 137–139, 141–167, 169–171, 173–175, 177–179, 181–205, 207–237, 239–241, 243–274, 276–283
   RogersActivity.swift96.77%100%95.83%240
   RogersUser.swift0%0%0%100–105, 107–135, 38–42, 44–53, 59–61, 63–79, 81–99
   URLTaskHelper.swift0%0%0%10–18, 7–9

@Nef10 Nef10 added minor This change should bump the minor version of the next release and removed major This change should bump the major version of the next release labels Dec 4, 2023
@Nef10 Nef10 merged commit 919c9bd into main Dec 4, 2023
4 checks passed
@Nef10 Nef10 deleted the postal-code branch December 4, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor This change should bump the minor version of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant