Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packer init #1

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Packer init #1

merged 1 commit into from
Jan 31, 2024

Conversation

walbertus
Copy link

Description

Fixes gruntwork-io#1271.

With this PR you can use directories for Packer templates

Release Notes (draft)

Added support for a directory in Packer template

Notes

I rebase it with the current upstream. You can check packer_test.go

@walbertus walbertus marked this pull request as ready for review January 30, 2024 15:44
@walbertus
Copy link
Author

@NefixEstrada can you help to check this?
I also rebase with the upstream master so the MR is pretty big. You can check the packer_test.go for the test

@walbertus
Copy link
Author

Unfortunately, there's no mechanism to check the Packer output. The test just makes sure there's no error thrown.

@NefixEstrada
Copy link
Owner

Hello @walbertus , I've rebased my branch with upstream. Could you please rebase your branch to mine to ensure only your test commit is added?

As for the Packer output in the test, I'm not sure if it's going to be enough for the terratest project, let's try that and see what they tell us.

Thanks for all your work!!

Néfix

Signed-off-by: William Albertus Dembo <29192168+walbertus@users.noreply.github.com>
@walbertus
Copy link
Author

Hi @NefixEstrada, I've rebased with your branch. It's only showing the correct files now.

@NefixEstrada NefixEstrada merged commit 2ea15d0 into NefixEstrada:master Jan 31, 2024
@NefixEstrada
Copy link
Owner

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants