support npm with github

[tjenkinson]

so that users can

npm install --save github:NeilFraser/JS-Interpreter

closes #156

See https://docs.npmjs.com/cli/install

I wondered if it would work without name but it's required. It's a bit misleading if someone else owns js-interpreter on npm. Ideally you would register a new name and use that to prevent any confusion.

[cpcallen]

I'm not clear on how to contact the person who currently owns the js-interpreter npm package, nor whether they would be willing and able to transfer it, but I would say it would be preferable for that npm to be owned by @NeilFraser, and for this PR to be accepted in support of having an official version whether under that name or another.

[Idrinth]

what about adding a scope, that would allow the distinction to the existing package: @neil-fraser/js-interpreter or something along those lines?

https://docs.npmjs.com/misc/scope

[tjenkinson]

👍 on the scoping. Is that @NeilFraser 's npm account?

[cpcallen]

Is that @NeilFraser 's npm account?

I rather doubt that @NeilFraser has an npm account. I might be guilty of understatement in describing him as being a bit dubious about the npm ecosystem. (I still think it would be preferable if he make his packages officially available there, though.)

[tjenkinson]

If he registers an account, even if he doesn't publish there, it would be better because we could use a scoped name that no one else could take then

[mercmobily]

I might be guilty of understatement in describing him as being a bit dubious about the npm ecosystem

Hopefully things have changed now in 2021 :D

[hsluoyz]

Any update?

[mercmobily]

I'm not clear on how to contact the person who currently owns the js-interpreter npm package, nor whether they would be willing and able to transfer it, but I would say it would be preferable for that npm to be owned by @NeilFraser, and for this PR to be accepted in support of having an official version whether under that name or another.

Please see my other ticket. #216 I will be totally happy to transfer ownership of it to you guys. But, I think we should spare a thought for those people who are currently using npm's js-interpreter so that we don't break things for them.

[mercmobily]

I had a look at this PR, and I wanted to add that doing this might not be enough:

if (typeof exports === 'object' && typeof module === 'object') {
  module.exports = Interpreter;
}

Mainly because of this line in js-interpreter:

Interpreter.nativeGlobal = this;

Sandwiching it might be a better option, since this will change its meaning depending on where it's being used. However, I am not the strongest JS person in my team. Raphael (in my team) will do a much better job than me at checking these sort of issues.

[cpcallen]

I'm on annual leave at the moment but will look at this when I get back to the office. Thanks @tjenkinson for the PR and @mercmobily for offering the use of the existing name. I'm not sure that @NeilFraser will be that keen to take on maintenance of the npm but we can probably work something out, especially if there are folks like you guys with the relevant experience who are willing to help out.

I agree that it would be best not to break things for users of the existing package.

[mercmobily]

No worries, let me know once you get back. In the meantime, I will leave the current js-interpreter npm package as is, waiting for your decision!
Thanks for taking the time to answer during your annual leave.

[derwehr]

Any chance this PR gets merged?
And is there currently another solution to install js-interpreter as a npm dependency?