Add adjoint for passive scalar (just T) #88 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advabp_adjoint has an extra term to be considered if ifheat is active convabp has one term less if ifadj is true. ADJOINT common block has extra variables. Last changes in the code for the temperature passive scalar adjoint, validated. perturb.f changed in advabp_adjoint and convabp. change of the comments
|
Is there any objection against merging this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
advabp_adjoint (in perturb.f): has an extra term to be considered if ifheat is active.
convabp (in perturb.f): has one term less if ifadj is true.
ADJOINT: has extra variables.
The changes in the code validated with Arnoldi (spectrum of adjoint and direct eigenvalues matching).