Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'o' and 'on' boundary conditions added to non-stress formulation. #99

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

mattiasbr
Copy link
Contributor

Enables the use of inhomogeneous 'O' and 'ON' boundary conditions (i.e. 'o' and 'on') of the form
nu dv/dy - p = pa
nu du/dx - p = pa
for non-stress formulation, where pa may be specified in userbc().

@pschlatt1
Copy link
Contributor

I think this pull request is ok, and should be merged.

@fischer1
Copy link
Contributor

fischer1 commented Oct 29, 2016

@ananiast Does this work also for pn/pn ? Or do we need to make an error check
if this BC is used for pn/pn ?

@mattiasbr Do we have an example by which we can test this feature ? - Paul

@fischer1 fischer1 self-assigned this Oct 29, 2016
@ananiast
Copy link

It won't be enough for Pn-Pn because we need to modify some other routines as well,
but it should be OK for Pn-Pn-2. I suggest we accept it but you should add an error check
about this

@stgeke
Copy link
Contributor

stgeke commented Nov 8, 2016

@ananiast should we merge this pull request?

@stgeke
Copy link
Contributor

stgeke commented Nov 30, 2016

@mattiasbr Please resolve the conflicts. Thanks!

@mattiasbr
Copy link
Contributor Author

The conflicts are now resolved and an error check for PnPn has been added to bcmask().

@pschlatt1
Copy link
Contributor

Can we merge it?

@stgeke
Copy link
Contributor

stgeke commented Dec 14, 2016

@ananiast Did you implement this change with another pull request?
In this case we can close the request w/o merging.

@stgeke stgeke merged commit 2987d17 into Nek5000:release/v16.0.0 Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants