Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set MPI ranks in test suite #15

Closed
RonRahaman opened this issue Jul 29, 2016 · 7 comments
Closed

Allow user to set MPI ranks in test suite #15

RonRahaman opened this issue Jul 29, 2016 · 7 comments
Assignees

Comments

@RonRahaman
Copy link
Contributor

Currently, the parallel test cases in NekTests.py are always run with 4 MPI ranks. We should allow the user to set the number of MPI ranks.

@maxhutch
Copy link
Contributor

Could we build this generally enough that a future test could be cross-validation vs number of ranks?

@RonRahaman
Copy link
Contributor Author

That's a great idea. The user could provide a list of ranks and the test case would handle it accordingly.

This would actually simplify the interfaces to the tests considerably. Right now, each test case has four methods. For example:

  • TurbChannel.test_PnPn_Serial (1 rank)
  • TurbChannel.test_PnPn_Parallel (4 ranks)
  • TurbChannel.test_PnPn2_Serial (1 rank)
  • TurbChannel.test_PnPn2_Parallel (4 ranks)

If we allow the user to specify a list of ranks, then we can reduce the test case methods to:

  • TurbChannel.test_PnPn
  • TurbChanneln.test_PnPn2
    Each method would perform the cross-validation with the given list or ranks. Or, if the list is a single value, no cross-validation would occur.

@stgeke
Copy link
Contributor

stgeke commented Aug 6, 2016

Do we also run serial tests w/o MPI?

@RonRahaman
Copy link
Contributor Author

We don't, I will add that as a separate issue.

@RonRahaman
Copy link
Contributor Author

Do we also run serial tests w/o MPI?

I added this issue to Nek5000/Nek5000#55

@fischer1
Copy link
Contributor

fischer1 commented Aug 9, 2016

Yes - I think this is important, since we advertise that we have this capability
and I use it regularly when debugging.


From: Ron Rahaman [notifications@github.com]
Sent: Tuesday, August 09, 2016 9:23 AM
To: Nek5000/NekExamples
Subject: Re: [Nek5000/NekExamples] Allow user to set MPI ranks in test suite (#15)

Do we also run serial tests w/o MPI?

I added this issue to Nek5000/Nek5000#55https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nek5000_Nek5000_issues_55&d=CwMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=bBKUKHeOUQYUUcfES2GnUlhzzfmhFc7KlYsosI2DIEU&m=IbsD84J6V2u_VNBY0jr_-Z3snBm8c0KVbjI6FdO52jw&s=6H3dxIzpKQ-nFF9jtkg1rrV4rr9yLwjwVAFBJeULWK0&e=


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nek5000_NekExamples_issues_15-23issuecomment-2D238569030&d=CwMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=bBKUKHeOUQYUUcfES2GnUlhzzfmhFc7KlYsosI2DIEU&m=IbsD84J6V2u_VNBY0jr_-Z3snBm8c0KVbjI6FdO52jw&s=jTMXlM1PvBffj6wxfX6BnB_h5PhNF55nWusvqOePpqQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKu-2DkXKbROy8-5FCXqDlBCzyCLUPwgO8hvks5qeI1jgaJpZM4JYaZU&d=CwMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=bBKUKHeOUQYUUcfES2GnUlhzzfmhFc7KlYsosI2DIEU&m=IbsD84J6V2u_VNBY0jr_-Z3snBm8c0KVbjI6FdO52jw&s=omYDCiQ-ai5GuUP4m9i6HuB8m2Omx7MxiVfiRbkzGho&e=.

@RonRahaman
Copy link
Contributor Author

Closed in PR #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants