Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webpack to peerDependencies #387

Closed
wants to merge 1 commit into from
Closed

Move webpack to peerDependencies #387

wants to merge 1 commit into from

Conversation

yesmeck
Copy link

@yesmeck yesmeck commented Jun 2, 2018

Since this plugin support both webpack 3 and 4, webpack should add as a peer dependency.

@NekR
Copy link
Owner

NekR commented Jun 2, 2018

Hi @yesmeck! Thanks for making this PR, it helped me find that all the dependencies were messed up die to npm 6's auto-adding dependencies on npm install.

I'm going to close this since there were more dependencies issues and I had to fix them myself, but many thanks anyway!

I've a new release already 👌

@NekR NekR closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants