Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue regarding to always run cacheAssets when running on current version #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/misc/sw-template.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@
"author": "Arthur Stolyar <nekr.fabula@gmail.com>",
"license": "MIT",
"dependencies": {
"babel": "^5.8.23",
"deep-extend": "^0.5.1",
"ejs": "^2.3.4",
"loader-utils": "0.2.x",
"minimatch": "^3.0.3",
"puppeteer": "^1.1.1",
"slash": "^1.0.0"
},
"bugs": {
Expand Down
2 changes: 1 addition & 1 deletion src/misc/sw-template.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function WebpackServiceWorker(params, helpers) {
const lastMap = lastData.hashmap;
const lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
CACHE MANIFEST
#ver:1123c8d59bc4f7b76256ee45664ecffdb06ffe92
#ver:4adc139f2cddd2a44418a4832f57a66ef829d686

CACHE:
/dist/main.js
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ var __wpo = {
"/images/logo_grey.svg"
],
"hashesMap": {
"e624017a102224fd7ed19f56813547cfa5fdf570": "/dist/main.js"
"b2e0d791f55cc3663324673d5d92ac61f6152a6a": "/dist/main.js"
},
"strategy": "changed",
"responseStrategy": "cache-first",
"version": "1123c8d59bc4f7b76256ee45664ecffdb06ffe92",
"version": "4adc139f2cddd2a44418a4832f57a66ef829d686",
"name": "webpack-offline",
"relativePaths": false
};

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function WebpackServiceWorker(params, helpers) {
var lastMap = lastData.hashmap;
var lastVersion = lastData.version;

if (!lastData.hashmap || lastVersion === params.version) {
if (!lastData.hashmap || lastVersion !== params.version) {
return cacheAssets(section);
}

Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.