-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pip-rating The Lord of the Words] Error ISO dateformat with Python 3.10 and previous versions #46
Comments
I just experienced the same error, while analysing the package
macOS 13.6, python 3.10, pip-rating 0.2.1 |
Hey @laureanorp ! Thanks for taking part of the conversation. I´m trying to backtrack this and this is what I´ve got so far. 🙏Please note my limited knowledge about the codebase, and please see this mental model more like a an intention of being part of brainstorming a possible solution without any kind of forcing intention to implement any of those by the maintainer 🙏 The ISO 8601 datetime format includes milliseconds, but the Here´s what I think that can be done
Happy to see more people around testing out this great project! |
Hi @SoyGema & @laureanorp , thank you very much for your comments and your interest in pip-rating! I am sorry I couldn't respond sooner, I didn't have my development environment on the laptop I brought to the conference. I have tried using Python 3.11.5 and I did not find the bug, but I did find it using 3.10.12. Python 3.10:
Python 3.11:
I have consulted the documentation and it seems that the My suggestion is a condition that checks the Python version. If the version is 3.11 or higher, Thank you both so much for your help with this bug. I should have tested better with different versions of Python! Next time, I won't trust unittests as much. Since you've helped so much, if you want you can contribute with a PR. Otherwise, I'll fix the bug tomorrow and release a new patch version as soon as possible. A big hug to both of you. See you at the next PyConES! |
Hey @Nekmo ! Thanks so much for your time, and for your openness towards accepting contribs 👍
Can you please take a look at the function above and validate if I understood the proposal correctly to submit a PR? I´m aware that the best practice is to directly sub PR but It would be awesome to align from a starting point with this in the sense of making two functions: one that can encapsulate conversions-python-dependent @Nekmo EDITED for clarification : I propose 2 functions for functionality and for keeping the
Looking forward to hear from you! 𝚆𝚑𝚢 𝚍𝚒𝚍 𝚝𝚑𝚎 𝙿𝚢𝚝𝚑𝚘𝚗 𝚙𝚛𝚘𝚐𝚛𝚊𝚖𝚖𝚎𝚛 𝚊𝚙𝚙𝚕𝚢 𝚏𝚘𝚛 𝚊 𝚓𝚘𝚋 𝚊𝚜 𝚊 𝚝𝚒𝚖𝚎 𝚝𝚛𝚊𝚟𝚎𝚕𝚎𝚛? |
Pull requests are always welcome! You can open a PR and I'll take a look at it soon. You can also ask me questions here :) I agree to create a file utils.py to include the new function
The code should not fail if it receives an unsupported date, but it should not fail silently either. Otherwise, it will be difficult to detect and fix the error if the date format changes in the future. If you can, include or modify the existing tests to check the modification. It would be great if you could reproduce the bug in a test and then fix it. If not, don't worry, I can take care of the tests. The code should have types. If you have any questions, just let me know. Thank you for your interest and for your time!
|
Hey @Nekmo ! I had a chance to give it a shot! |
If you need help, just tell me :) |
Command that causes the issue
Context
Congrats on the project and the great lighting talk at PyConES2023 !
Really great project. Thanks for contributing to the community. Keep the great work up! 👍
I´m testing out under the context of The Lord of The Words project
So I go to the project folder after
pip install pip-rating
and run
Expected behavior
Hypothesis
click
isodate format workingActual behavior
It does indeed start analyzing dependencies, but at some point it shows the following error.
Posting here full-trace
Interpretation
I´m still getting familiarized with some details, but what I´m understanding ( please, don´t hesitate to tell me if I´m wrong or pointing me out to the right direction ) is that this might be related with click date conversion somehow?
The mental model under the
click
choice hypothesis is based on part of the following trace, but I might be wrong!When I go here , what Im understanding is that you are trying to use a delta-time to determine somehow a "time-trusted-score" based on when was it updated and now?
Traceback
No response
Pip-rating version
Info
pip-rating 0.2.1
🔝 This is the latest version.
🐍 Python version: 3.10.10
💻 Platform: macOS-13.4.1-arm64-arm-64bit
Other details
I really found useful the tool verbosity, as I could see that It was going down in the analysis.
Congrats for bringing transparency to OSS maintenance!
Checklist
pip install -U pip-rating
and triggered the bug in the latest version.The text was updated successfully, but these errors were encountered: