Skip to content

Commit 0a826c4

Browse files
committed
Improve GpuBuffer constructor consistency
1 parent a96266e commit 0a826c4

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/gpu_buffer.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ GpuBuffer& GpuBuffer::operator=(GpuBuffer&& other)
6767
}
6868

6969
GpuBuffer::GpuBuffer(
70-
WGPUDevice device,
71-
const char* label,
72-
std::size_t byteSize,
73-
WGPUBufferUsageFlags usage)
70+
const WGPUDevice device,
71+
const char* const label,
72+
const WGPUBufferUsageFlags usage,
73+
const std::size_t byteSize)
7474
: mBuffer(nullptr),
7575
mByteSize(byteSize),
7676
mUsage(usage)

src/gpu_buffer.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ class GpuBuffer
2727
GpuBuffer(
2828
WGPUDevice device,
2929
const char* label,
30-
std::size_t byteSize,
31-
WGPUBufferUsageFlags usage);
30+
WGPUBufferUsageFlags usage,
31+
std::size_t byteSize);
3232

3333
template<typename T>
3434
GpuBuffer(

src/renderer.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,18 @@ Renderer::Renderer(const RendererDescriptor& rendererDesc, const GpuContext& gpu
5757
: frameDataBuffer(
5858
gpuContext.device,
5959
"frame data buffer",
60-
sizeof(FrameDataBuffer),
61-
WGPUBufferUsage_CopyDst | WGPUBufferUsage_Uniform),
60+
WGPUBufferUsage_CopyDst | WGPUBufferUsage_Uniform,
61+
sizeof(FrameDataBuffer)),
6262
pixelBuffer(
6363
gpuContext.device,
6464
"pixel buffer",
65+
WGPUBufferUsage_CopyDst | WGPUBufferUsage_Storage,
6566
[&rendererDesc]() -> std::size_t {
6667
const Extent2i largestResolution = rendererDesc.maxFramebufferSize;
6768
const std::size_t numPixels =
6869
static_cast<std::size_t>(largestResolution.x * largestResolution.y);
6970
return sizeof(glm::vec3) * numPixels;
70-
}(),
71-
WGPUBufferUsage_CopyDst | WGPUBufferUsage_Storage),
71+
}()),
7272
computePixelsBindGroup(nullptr),
7373
computePipeline(nullptr),
7474
vertexBuffer(),

0 commit comments

Comments
 (0)