Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the project and new options added #26

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

elchininet
Copy link
Collaborator

@elchininet elchininet commented Mar 25, 2023

This pull request refactors the code to make it easier to add new styles and to extend the functionality of the library, making the code more readable and avoiding unwanted mistakes during styles coding.

As part of this pull request new options have been added to the library, allowing one to hide elements from the overflow menu on the top right corner. It also implements a better way to hide the Search and the Assistant buttons, so, if these options are used, it will also affect these buttons when they are inside the top right overflow menu on small screens.

Option Hides
hide_search Hides the search button on the top menu and inside the overflow menu on small screens
hide_assistant Hides the assistant button on the top menu and inside the overflow menu on small screens
hide_edit_dashboard Hides the "Edit dashboard" button inside the overflow menu
hide_refresh Hides the "Refresh" button inside the overflow menu in lovelace yaml mode
hide_unused_entities Hides the "Unused entities" button inside the overflow menu in lovelace yaml mode
hide_reload_resources Hides the "Reload resources" button inside the overflow menu in lovelace yaml mode

If some of these options are used in a way that the overflow menu ends up empty, it will hide (same as using the option hide_overflow).

Closes #14

Note: this pull request depends on #25, it contains the same changes contained in the aforementioned pull request. After #25 gets merged, this branch should be rebased to keep only the changes relatives to the new features introduced here.

@elchininet elchininet added the enhancement New feature or request label Mar 25, 2023
@elchininet elchininet marked this pull request as draft March 26, 2023 23:05
@elchininet elchininet added the 📝 documentation Improvements or additions to documentation label Apr 3, 2023
@elchininet elchininet force-pushed the implement_hide_edit_dashboard branch from ed26e1f to c1c2912 Compare April 6, 2023 17:23
@elchininet elchininet marked this pull request as ready for review April 6, 2023 17:23
@elchininet
Copy link
Collaborator Author

@NemesisRE, this one is ready. It is better to wait for the last pull request to make a release with all the changes.
If new versions pop up people will think that it is the version that fixes Home Assistant compatibilities.

@NemesisRE
Copy link
Owner

alright sounds good then we wait for #28 to be ready and merge them both at once as version 1.9 or so

@elchininet
Copy link
Collaborator Author

@NemesisRE,
Yes, that would be the best approach.
Did you check this one, it implements a lot of features. Can I merge it?

@NemesisRE
Copy link
Owner

The features looked good for me

@elchininet elchininet merged commit a0795a8 into master Apr 6, 2023
@elchininet elchininet deleted the implement_hide_edit_dashboard branch April 6, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: add option to hide items in Menu
2 participants