Make base_ring_type work for (M)SeriesRing #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These signatures were wrong but since we run no conformance tests on these rings we never noticed...
fingolfin
force-pushed
the
mh/base_ring_type-series
branch
from
d17f51e
to
2c97f0c
Compare
fingolfin
force-pushed
the
mh/base_ring_type-series
branch
from
2c97f0c
to
5cebfcc
Compare
|
I disabled the failing conformance test for SparsePoly (and added another commented out conformance test for function fields, which seems to trigger an endless loop somewhere ...). Assuming this passes I hope we can merge it |
This was referenced Apr 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
- Coverage 86.97% 86.91% -0.07%
==========================================
Files 116 116
Lines 29715 29689 -26
==========================================
- Hits 25846 25805 -41
- Misses 3869 3884 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These signatures were wrong but since we run no conformance tests on
these rings we never noticed...
Of course there should also be tests. But guess what, rings that we did not conformance tests are not conformant... plus one has to add `test_elem` methods in order to run the conformance tests.So let's get this fix out now and add tests later.UPDATE: Actually it wasn't so bad to get the conformance tests added, I just made a silly mistake earlier. So I added those tests now and a few extra ones as bonus. Problems only pop up with the "recursive" conformance tests, which I therefore skipped. (Several ring types still are not tested for conformance at all.)