Adress some more JET warnings #1709
Conversation
| @@ -552,8 +552,8 @@ end | |||
| # | |||
| ################################################################################ | |||
|
|
|||
| mutable struct printer | |||
| io::IO | |||
| mutable struct printer{IOT <: IO} | |||
There was a problem hiding this comment.
This makes all functions using this printer thing type-stable (as they eventually access the underlying IO)
| return a([one(base_ring(a))], reshape([[UInt(j == n - i + 1) | ||
| for j in 1:n]..., UInt(1)], n + 1, 1)) | ||
| return a([one(base_ring(a))], reshape(UInt[(UInt(j == n - i + 1) | ||
| for j in 1:n)..., UInt(1)], n + 1, 1)) |
There was a problem hiding this comment.
The input of reshape got inferred as Vector{Any}. This additional type annot helps. And additionally, I got rid of some allocations by not creating the inner vector.
| @@ -24,7 +24,7 @@ function is_exact_type(::Type{T}) where {S <: RingElement, U <: MPolyRingElem{S} | |||
| return is_exact_type(S) | |||
| end | |||
|
|
|||
| parent(p::UnivPoly) = p.parent | |||
| parent(p::UnivPoly) = p.parent::parent_type(p) | |||
There was a problem hiding this comment.
somehow julia couldn't infer p.parent properly, the second type param (the MPolyRing) abstract. Additionally use this accessor everywhere in this file instead of direct access
|
Furthermore, there is some issue with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1709 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 117 117
Lines 29824 29824
=======================================
Hits 26045 26045
Misses 3779 3779 ☔ View full report in Codecov by Sentry. |
No description provided.