fix #467, "docstring oddities #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perl command:
perl -i -p -e 'BEGIN{undef $/;} s/"""\n (\S)/"""\n \1/smg' $(find -name \*\.jl)
Perl command:
perl -i -p -e 'BEGIN{undef $/;} s/"""\n (\S.*)\n>/"""\n \1\n\n>/g' $(find -name \*\.jl)
Perl commands: perl -i -p -e 's/^> (.+)/\1/g' $(find -name \*\.jl) perl -i -p -e 's/^>$//g' $(find -name \*\.jl)
|
Looks like this causes the docs to stop building. See the documentation test on travis. |
|
On Mon, Oct 26, 2020 at 03:15:51PM -0700, wbhart wrote:
Looks like this causes the docs to stop building. See the documentation test on travis.
Not helpful, but looks like an error in documenter
…
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#662 (comment)
|
Yes... I force-pushed on another PR to check if the build still passes there. |
|
A painfully boring bisection allowed to find the problem, a |
|
The julia markdown parser is very brittle when it comes to |
|
There is also this issue: JuliaDocs/Documenter.jl#1020 |
This was referenced Oct 28, 2020
rfourquet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thee commits (which make it easier to review, so github highlights the parts which changed)
>characters at the beginning of lines in docstrings.I used Perl commands (included in the commit messages), so this limit the chance for human errors, but I'm not expert in regexes either... I also reviewed "manually", and this seems to have done what was expected.