Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More adjustments for FqField #1411

Merged
merged 6 commits into from
Mar 16, 2023
Merged

More adjustments for FqField #1411

merged 6 commits into from
Mar 16, 2023

Conversation

thofma
Copy link
Member

@thofma thofma commented Mar 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1411 (262ba4a) into master (ac1add1) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
+ Coverage   88.71%   88.88%   +0.16%     
==========================================
  Files          88       88              
  Lines       34396    34463      +67     
==========================================
+ Hits        30514    30632     +118     
+ Misses       3882     3831      -51     
Impacted Files Coverage Δ
src/gaussiannumbers/continued_fraction.jl 100.00% <ø> (ø)
src/Nemo.jl 29.88% <100.00%> (+0.81%) ⬆️
src/flint/FlintTypes.jl 94.82% <100.00%> (+<0.01%) ⬆️
src/flint/fq.jl 93.77% <100.00%> (+0.25%) ⬆️
src/flint/fq_default.jl 93.89% <100.00%> (-0.06%) ⬇️
src/flint/fq_default_extended.jl 100.00% <100.00%> (ø)
src/flint/fq_default_poly.jl 91.13% <100.00%> (+0.04%) ⬆️
src/flint/fq_nmod.jl 92.38% <100.00%> (+0.27%) ⬆️

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma thofma closed this Mar 15, 2023
@thofma thofma reopened this Mar 15, 2023
@thofma
Copy link
Member Author

thofma commented Mar 15, 2023

Does anyone know what is up with the downstream tests? @benlorenz @fingolfin any clue?

@benlorenz
Copy link
Collaborator

Does anyone know what is up with the downstream tests? @benlorenz @fingolfin any clue?

Slightly different indent, see #1414. That PR has the OscarCI tests, but it needs approval to run.

@thofma thofma closed this Mar 16, 2023
@thofma thofma reopened this Mar 16, 2023
@thofma thofma merged commit b4f72f3 into master Mar 16, 2023
@thofma thofma deleted the th/fixfq branch March 16, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants