Add .editorconfig
#1697
Add .editorconfig
#1697
Conversation
| insert_final_newline = true | ||
|
|
||
| [*.jl] | ||
| indent_size = 3 |
There was a problem hiding this comment.
I guess this does indeed match what the majority of the code does, but it's a bit jarring that it again differs from Oscar.jl and other of our packages...
Since we are currently down to just one other PR. perhaps it is time to think about running JuliaFormatter on the entire package (might make @lkastner happy, too), with whatever settings we prefer (i.e. we'd also need a JuliaFormatter.toml)
There was a problem hiding this comment.
Also fine by me. The same should then be done for AbstractAlgebra.
There was a problem hiding this comment.
See #1698 for a proposal.
There was a problem hiding this comment.
Also fine by me. The same should then be done for AbstractAlgebra.
Adding the formatting config, yes. With running the formatter on everything I would wait for a moment with only few open relevant PRs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1697 +/- ##
==========================================
- Coverage 84.70% 84.67% -0.03%
==========================================
Files 94 94
Lines 37460 37460
==========================================
- Hits 31729 31718 -11
- Misses 5731 5742 +11 ☔ View full report in Codecov by Sentry. |
|
Closing in favour of #1698. |
I think it is supposed to be 3 spaces per tab in Nemo.