Consistently use ZZ/QQ instead of mix of ZZ/QQ and FlintZZ/FlintQQ
#1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/FlintQQZZ
branch
2 times, most recently
from
03d42cb
to
ba5f1d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1718 +/- ##
==========================================
- Coverage 84.92% 84.90% -0.02%
==========================================
Files 95 95
Lines 37235 37235
==========================================
- Hits 31620 31614 -6
- Misses 5615 5621 +6 ☔ View full report in Codecov by Sentry. |
fingolfin
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Presumably this was done to 100% exclude any chance of confusion as to which QQ and ZZ is used, to catch any mistakes where perhaps the alternative definitions in AA get imported by accident somewhere.
But it seems to me we have established quite clearly this is not the case, so I am OK with making this change...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the code more consistent and readable. The objects
FlintZZandFlintQQstay for compatibility reasons.