Fix (P/Q)adicFieldElem printing in poly ring elems #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closed in favor of thofma/Hecke.jl#1536 |
|
Hm, the types here and in thofma/Hecke.jl#1536 have nothing in common I think? |
|
Yeah, I got confused by an older Hecke version and mismatched QadicRingElem with QadicFieldElem |
|
So this PR doesn't change anything with regards to fixing thofma/Hecke.jl#1535 and is just an unnecessary change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves thofma/Hecke.jl#1535 in a similar way to Nemocas/AbstractAlgebra.jl#1667. The same issue was there for
PadicFieldElemas well, and the tests for this were easier to adapt.Let's hope that the wrong behavior is not doctested downstream.