Rename some arb-backed types #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
+ Coverage 86.05% 86.08% +0.03%
==========================================
Files 98 98
Lines 36402 36402
==========================================
+ Hits 31326 31338 +12
+ Misses 5076 5064 -12 ☔ View full report in Codecov by Sentry. |
lgoettgens
changed the title
fingolfin
reviewed
Jul 12, 2024
| RealField() => RealMat, | ||
| ComplexField() => ComplexMat, | ||
| RealField() => RealMatrix, | ||
| ComplexField() => ComplexMatrix, |
There was a problem hiding this comment.
Independent of this PR: can't we replace ring_to_mat by suitable use of dense_matrix_type?
There was a problem hiding this comment.
Yeah, should be possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1772, resolves #1769.
Currently only still adds
@aliass, that should be changed to@deprecate_bindingin the next breaking release.