Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 : Project header #22

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Milestone 1 : Project header #22

merged 5 commits into from
Mar 8, 2022

Conversation

Nemwel-Boniface
Copy link
Owner

@Nemwel-Boniface Nemwel-Boniface commented Mar 8, 2022

Hello @zmekonnen251 馃憢 馃憢

For this part of the milestone I have managed to :

  • Include the markup for the project navigation bat
  • Included links to fonts using Mochiy pop one, and Poppins
  • Included Styling for the project (desktop version only)
  • Included some animations for the logo
  • Included project setup files, linters, and jest
  • Checked and fixed linter errors
  • Followed list of best practices for JavaScript.
  • Met all the project milestone requirements
  • No linter errors

Thank you for taking the time to review my changes.

Copy link
Collaborator

@zmekonnen251 zmekonnen251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nemwel-Boniface,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

@zmekonnen251 zmekonnen251 merged commit 0c202dc into projectSetUp Mar 8, 2022
@zmekonnen251 zmekonnen251 deleted the projectHeader branch March 8, 2022 07:46
@Nemwel-Boniface Nemwel-Boniface changed the title Milestone 2 : Project header Milestone 1 : Project header Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants