Milestone 5 : Comment popup (#14) #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-modifed display page in index.js to uinique id of the cards
Create html elements dynamically for the comment popup Add event listener for the comment and and close buttons
make the posiotion fixed and blured the background
Nemwel-Boniface
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Hello @zmekonnen251 👋 👋
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉 Even Kanye approves 🥳
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Milestone I did:
General requirements
JavaScript requirements
Project requirements
Thank you for reviewing!:smile: