Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 9 : Add a test for comment counter #30

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

zmekonnen251
Copy link
Collaborator

In the Milestone I did:

General requirements

  • There are no linter errors.
  • Followed the Gitflow.
  • The documentation is professional.

JavaScript requirements

Project requirements

  • Add test for the comment counter

Thank you for reviewing!

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for happy-payne-5d37ab ready!

🔨 Explore the source changes: 40412b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/happy-payne-5d37ab/deploys/62292d1a1674c800079b3822

😎 Browse the preview: https://deploy-preview-30--happy-payne-5d37ab.netlify.app

Copy link
Owner

@Nemwel-Boniface Nemwel-Boniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zmekonnen251 👋 👋

Your project is complete! 🥳
Great job implementing the Unit tests they all pass 😎 😎
There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

@Nemwel-Boniface Nemwel-Boniface merged commit 2846bd7 into development Mar 10, 2022
@Nemwel-Boniface Nemwel-Boniface deleted the comment-counter-test branch March 10, 2022 03:52
@Nemwel-Boniface Nemwel-Boniface changed the title Add a test for comment counter Milestone 9 : Add a test for comment counter Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants