-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Munin incorrectly writes semicolon-delimited files instead of CSVs #55
Comments
@Neo23x0 I've been playing around with the code a bit - is it intended functionality to end all lines with the delimiter? (I'm not aware that that's common CSV definition either). Currently the header line for example comes out:
Edit: I ask because I would "fix" this in a PR that adds CSV functionality (where the C=comma), but if it's intended functionality, that would potentially break some existing parsers. I'm also considering adding an option for quoted CSVs (Excel compatible with character escaping) - is this something you're interested in? Edit 2:
|
@graememeyer @Neo23x0 Due to the delimiter being a semicolon the CSV is not valid, because some of the column values contain semicola themselves, thus giving pretending to be more columns than there should be. I fixed this in PR #66. Since PR #59 is also tackling this problem, I did not quote the column. Further, in my assumption the trailing delimiters arise due the fact that each element is added with a dedicated write to the file. Since then you don't know which one is the last element added you have to add the |
It appears the latest version of munin is writing output files delimited by semicolon characters (
;
) rather than commas (,
), even when the-o
option is applied.Example:
Output:
I feel like this issue is too obvious to have gone unnoticed, so perhaps it's intentional? If so, the documentation should be updated to reflect this, and ideally an actual CSV option added. I am happy to contribute this if you can confirm my findings and the intentionality of the issue.
The text was updated successfully, but these errors were encountered: