Replace Command handler with libsu #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toybox is shipped with Android and offers the needed functionality
Changed: Refactored doBackup method to use new libsu wrapper + minor logic changes Changed: Check for toybox. It can also be busybox. Renamed the variable to have consistent name Changed: killPackage, setPermissions, checkToybox use libsu wrapper Fixed: compressing detects if a target does not exists and aborts without failing to avoid triggering errors Added: Utility functions to convert iterables to a String (used to convert libsu stdout and stderr to simple strings) Sorry for the long list of changes. It just happened
|
Rebased changes onto changes up to release 1.3.0 |
Changed: Refactored doRestore, restoreUserApk, restoreSystemApk, uninstall, getUsers and getDisabledPackages to use libsu wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libsu keeps a shell open in the background. This reduces a huge overhead caused by numerous
sucalls especially during backup/restore.It changed a lot. It should be well tested.
/update:
Contains changes from PR #50 "Removed: oab-utils in favour of toybox."
toybox is shipped with Android and offers the needed functionality
Toyboxs is shipped since Android 6, but OEMs could have removed it. On these devices/configuration oandbackupx won't work.