Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast and accurate undistortion #269

Closed
oleg-alexandrov opened this issue Jun 11, 2019 · 1 comment
Closed

Fast and accurate undistortion #269

oleg-alexandrov opened this issue Jun 11, 2019 · 1 comment

Comments

@oleg-alexandrov
Copy link
Member

For some distortion models the distortion is computed by a formula, and undistortion needs to be inverted which is very slow. For others it is the reverse. We currently have a bit of haphazard fix for this, where, for example, Brown Conrady and Photometrix models are approximated with a Tsai model on the fly. The latter has two radial distortion and two two tangential distortion coefficients. It is not clear that this is enough.

When the cameras have Tsai distortion to start with, then undistortion is slow, and I don't think we do anything for that.

Lastly, for both Tsai and RPC we compute the the approximation that results in a fast model by using an initial guess for zero distortion and optimizing it. This can run into local minima and produce a poor approximation, particularly for high-degree RPC.

I think some careful thinking needs to be done about how to best support distortion and fast evaluation of distortion/undistortion in our software.

@oleg-alexandrov
Copy link
Member Author

This hasn't been an issue in practice. ASP ships now an auxiliary tool named undistort_image_texrecon that is meant to be used with recently added meshing and texturing functionality. This handles undistortion by interpolating into a lookup table, and also has the ability to set the domain of distortion and undistortion. If needed, could be expanded to a more general solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant