Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor popup logic #5

Closed
NeoLegends opened this issue Mar 16, 2019 · 3 comments
Closed

Refactor popup logic #5

NeoLegends opened this issue Mar 16, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@NeoLegends
Copy link
Owner

Booking & renting logic is currently split between the bike-map and rent-popup components. This creates some complications in regards to clear separation of concerns. We should move the booking & renting logic into rent-popup entirely.

@LucasForster
Copy link
Contributor

Basically, you would remove the "Active reservation" field from the "Bookings"-tab.

It contains the following information which needs to be integrated into the rent-popup:

  • Station name
    This is basically covered by the rent-popup: When open, you either see a station name in the "Cancel booking"-button, or nothing, which means that the booking is for this particular station.

    However, this might be a bit unclear when you're actually not remembering which station you booked. The information should be integrated into the map (without opening a station) e.g. by changing the station icon to, let's say, a gear wheel containing an 'R' for "reservation".

  • The reserved slot's number
    This is already fully integrated into the rent-popup: When selecting or booking a bike, the slot gets pre-selected (and you can choose another bike if you want to).

  • The time until the booking is valid
    This could be integrated directly into the rent-popup as an information below the cancellation button (something like "auto-cancelling in ..."). With more effort, the "reserved logo" described above could carry this information in its color (changing from green to red when the time runs out).

@NeoLegends
Copy link
Owner Author

Basically, you would remove the "Active reservation" field from the "Bookings"-tab.

Nah, this ticket is solely related to the code base, not to anything user-related.

@NeoLegends
Copy link
Owner Author

I'm open to making the rent popup take over the responsibilities of the bookings tab in regards to the currently active booking, but let's create a separate issue for that.

@NeoLegends NeoLegends added the enhancement New feature or request label Mar 16, 2019
NeoLegends added a commit that referenced this issue Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants