Skip to content

Commit

Permalink
- Modificado el CodePatterns para añadir valores por defecto de fecha…
Browse files Browse the repository at this point in the history 
…, hora y número.

- Añadido el correspondiente test unitario.
  • Loading branch information
Carlos García Gómez committed Nov 30, 2021
1 parent f36bd7b commit a2b5531
Show file tree
Hide file tree
Showing 2 changed files with 184 additions and 18 deletions.
48 changes: 30 additions & 18 deletions Core/Lib/CodePatterns.php
View file
Expand Up @@ -29,7 +29,6 @@
*/
class CodePatterns
{

const DATE_STYLE = 'd-m-Y';
const DATETIME_STYLE = 'd-m-Y H:i:s';
const HOUR_STYLE = 'H:i:s';
Expand All @@ -48,29 +47,42 @@ class CodePatterns
*/
public static function trans(string $text, &$model, array $options = []): string
{
// columnas
$colFecha = $options['fecha'] ?? 'fecha';
$colHora = $options['hora'] ?? 'hora';
$colNumero = $options['numero'] ?? 'numero';
$colSerie = $options['serie'] ?? 'codserie';
$colEjercicio = $options['ejercicio'] ?? 'codejercicio';

// valores
$ejercicio = $model->{$colEjercicio} ?? '';
$fecha = $model->{$colFecha} ?? date(self::DATE_STYLE);
$hora = $model->{$colHora} ?? date(self::HOUR_STYLE);
$long = $options['long'] ?? 0;
$date = $options['fecha'] ?? 'fecha';
$number = $options['numero'] ?? 'numero';
$serie = $options['serie'] ?? 'codserie';
$ejerc = $options['ejercicio'] ?? 'codejercicio';
$numero = $model->{$colNumero} ?? 0;
$serie = $model->{$colSerie} ?? '';

// El separador | sirve para aplicar filtros. Usaremos solamente la primera parte para transformar
$parts = explode('|', $text);

// transformación
$result = strtr($parts[0], [
'{FECHA}' => date(self::DATE_STYLE),
'{HORA}' => date(self::HOUR_STYLE),
'{FECHAHORA}' => date(self::DATETIME_STYLE),
'{ANYO}' => date('Y', strtotime($model->{$date})),
'{DIA}' => date('d', strtotime($model->{$date})),
'{EJE}' => $model->{$ejerc},
'{EJE2}' => substr($model->{$ejerc}, -2),
'{MES}' => date('m', strtotime($model->{$date})),
'{NUM}' => $model->{$number},
'{SERIE}' => $model->{$serie},
'{0NUM}' => str_pad($model->{$number}, $long, '0', STR_PAD_LEFT),
'{0SERIE}' => str_pad($model->{$serie}, 2, '0', STR_PAD_LEFT),
'{NOMBREMES}' => ToolBox::i18n()->trans(strtolower(date('F', strtotime($model->{$date}))))
'{FECHA}' => date(self::DATE_STYLE, strtotime($fecha)),
'{HORA}' => date(self::HOUR_STYLE, strtotime($hora)),
'{FECHAHORA}' => date(self::DATETIME_STYLE, strtotime($fecha . ' ' . $hora)),
'{ANYO}' => date('Y', strtotime($fecha)),
'{DIA}' => date('d', strtotime($fecha)),
'{EJE}' => $ejercicio,
'{EJE2}' => substr($ejercicio, -2),
'{MES}' => date('m', strtotime($fecha)),
'{NUM}' => $numero,
'{SERIE}' => $serie,
'{0NUM}' => str_pad($numero, $long, '0', STR_PAD_LEFT),
'{0SERIE}' => str_pad($serie, 2, '0', STR_PAD_LEFT),
'{NOMBREMES}' => ToolBox::i18n()->trans(strtolower(date('F', strtotime($fecha))))
]);

// si hay filtros, los aplicamos ahora
return count($parts) > 1 ? static::format($result, $parts[1]) : $result;
}

Expand Down
154 changes: 154 additions & 0 deletions Test/Core/Lib/CodePatternsTest.php
View file
@@ -0,0 +1,154 @@
<?php
/**
* This file is part of FacturaScripts
* Copyright (C) 2017-2021 Carlos Garcia Gomez <carlos@facturascripts.com>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

namespace FacturaScripts\Test\Core\Lib;

use FacturaScripts\Core\Lib\CodePatterns;
use FacturaScripts\Core\Model\PedidoCliente;
use FacturaScripts\Core\Model\Producto;
use PHPUnit\Framework\TestCase;

final class CodePatternsTest extends TestCase
{
public function testDefault()
{
$order = new PedidoCliente();
$order->codejercicio = '2021';
$order->codserie = 'A';
$order->numero = '1';

$code = CodePatterns::trans('PED{EJE}{SERIE}{NUM}', $order);
$this->assertEquals('PED2021A1', $code, 'different-code');
}

public function testZeroNum()
{
$order = new PedidoCliente();
$order->codejercicio = '2021';
$order->codserie = 'A';
$order->numero = '22';

$code = CodePatterns::trans('PED{EJE}{SERIE}{0NUM}', $order, ['long' => 6]);
$this->assertEquals('PED2021A000022', $code, 'different-code');
}

public function testEje2()
{
$order = new PedidoCliente();
$order->codejercicio = '2022';
$order->codserie = 'A';
$order->numero = '555';

$code = CodePatterns::trans('PED{EJE2}{SERIE}{0NUM}', $order, ['long' => 6]);
$this->assertEquals('PED22A000555', $code, 'different-code');
}

public function testZeroSerie()
{
$order = new PedidoCliente();
$order->codejercicio = '2022';
$order->codserie = 'C';
$order->numero = '9999';

$code = CodePatterns::trans('{EJE2}{0SERIE}{0NUM}', $order, ['long' => 6]);
$this->assertEquals('220C009999', $code, 'different-code');
}

public function testAnyoMesDiaNum()
{
$order = new PedidoCliente();
$order->codejercicio = '2022';
$order->codserie = 'C';
$order->fecha = '23-11-2021';
$order->numero = '777';

$code = CodePatterns::trans('{ANYO}-{MES}-{DIA}-{NUM}', $order);
$this->assertEquals('2021-11-23-777', $code, 'different-code');
}

public function testNombreMesNum()
{
$order = new PedidoCliente();
$order->codejercicio = '2020';
$order->codserie = 'A';
$order->fecha = '23-03-2021';
$order->numero = '123';

$code = CodePatterns::trans('{SERIE}-{NOMBREMES}-{NUM}', $order);
$this->assertEquals('A-Marzo-123', $code, 'different-code');
}

public function testDateNum()
{
$order = new PedidoCliente();
$order->codejercicio = '2020';
$order->codserie = 'A';
$order->fecha = '02-03-2021';
$order->hora = '11:22:33';
$order->numero = '87';

$code = CodePatterns::trans('{SERIE}{NUM}-{FECHA}-{HORA}', $order);
$this->assertEquals('A87-02-03-2021-11:22:33', $code, 'different-code');
}

public function testDateTimeNum()
{
$order = new PedidoCliente();
$order->codejercicio = '2020';
$order->codserie = 'Z';
$order->fecha = '07-07-2020';
$order->hora = '15:16:17';
$order->numero = '88';

$code = CodePatterns::trans('{SERIE}{NUM}-{FECHAHORA}', $order);
$this->assertEquals('Z88-07-07-2020 15:16:17', $code, 'different-code');
}

public function testFilters()
{
$order = new PedidoCliente();
$order->codejercicio = '2020';
$order->codserie = 'Z';
$order->numero = '63';

$code1 = CodePatterns::trans('pEd{EJE}{SERIE}{NUM}ccc|M', $order);
$this->assertEquals('PED2020Z63CCC', $code1, 'upper-fail');

$code2 = CodePatterns::trans('pEd{EJE}{SERIE}{NUM}ccc|m', $order);
$this->assertEquals('ped2020z63ccc', $code2, 'lower-fail');

$code3 = CodePatterns::trans('pEd{EJE}{SERIE}{NUM}ccc|P', $order);
$this->assertEquals('PEd2020Z63ccc', $code3, 'uc-first-fail');
}

public function testNoBusinessDoc()
{
$product = new Producto();
$product->actualizado = '03-04-2021 11:33:55';
$product->codfamilia = 'J';
$product->referencia = '999';

$code = CodePatterns::trans('{SERIE}{NUM}-{FECHA}', $product, [
'fecha' => 'actualizado',
'numero' => 'referencia',
'serie' => 'codfamilia'
]);
$this->assertEquals('J999-03-04-2021', $code, 'different-code');
}
}

0 comments on commit a2b5531

Please sign in to comment.