Refactoring the API library #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoRazorX
requested changes
Apr 22, 2018
Core/App/AppAPI.php
Outdated
| use FacturaScripts\Core\Model\ApiKey; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| \define('API_FOLDER', 'Dinamic\\Lib\\API\\'); |
There was a problem hiding this comment.
Define is used to create constants that are used throughout the application. This is not the case. Please revert these modifications.
There was a problem hiding this comment.
Reversed modifications.
NeoRazorX
approved these changes
Apr 24, 2018
NeoRazorX
added a commit
that referenced
this pull request
Mar 11, 2020
Task #403: Modified BusinessDocumentView.js to set more values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model API is extracted and a general-purpose generic kernel is created.