Modify LineaTransferenciaStock to update stock transferring (Trello#498) #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoRazorX
requested changes
Aug 1, 2018
| * | ||
| * @param string $action | ||
| */ | ||
| protected function execPreviousAction($action) |
There was a problem hiding this comment.
the work does not fit the description. The work had to be done in the model, not in the controller
| @@ -94,4 +99,57 @@ public static function tableName() | |||
| { | |||
| return 'lineastransferenciasstock'; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
class core/model/base/businessdocumentline.php has not been used as a guide. If you look at the class you will see that it is already responsible for knowing what the initial amount was. You do not need the controller to tell you.
transferTo(almacéndestino, cantidad) - En LineaTransferenciaStock se crea delete, que localiza el movimiento de stock y lo retrocede, para posteriormente invocar al delete que elimina el registro de líneastock. - EditTransferenciaStock queda inconcluso y a medio terminar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the LineaTransferenciaStock model so that the stock transfer becomes effective when making a save.