Integrate wallet providers #65

corollari · 2019-07-10T07:06:00Z

Integrates NEOLine, enabling the use of the account stored in the extension to deploy and invoke smart contracts.
Currently deploying is not working due to what I believe to be issues with NEOLine itself, I've notified upstream and once issues are fixed there this PR should work fine.

Posting it here so that if other people try to implement it they will see this and won't have to redo the work I've done.

If you believe this should only be posted once it's ready to be merged feel free to close it directly.

vncoelho · 2019-07-10T07:46:54Z

You are more than welcome, @collari.
That is a great work!

We can give you permission to direct edit here as well if you want.

I will test the PR and install NeoLine here as well.
We could also update the Readme with a guidelines for NeoLine, yes?

public/js/eco-scripts/invoke_deploy_NeonJS.js

public/partials/ecolab.html

vncoelho · 2019-07-10T16:34:12Z

Thanks for the integration, @corollari,

I do not know why but our github does not show the button to upon with master. Thus, there are some duplicated things from the previous commit.

I left some minor comments, let's finish this integration, it will be nice!

corollari · 2019-10-13T12:41:00Z

The last commit addresses the changes you requested (clean the code, re-organize it into functions to reduce duplication and change the network selection UI) and extend the integration to O3 and NeoLogin.

Full disclosure: I'm the lead dev of NeoLogin

corollari · 2019-10-27T23:44:18Z

Pushed an update that shows the wallets only if they are available (user has them installed). Before they always showed up but if a user tried to select them but they didn't have them installed an error would pop up.

If in your opinion it was better before I can just revert it.

vncoelho

Great job, @corollari.

I still need to test. I am just checking the code for now.

I believe it might be almost ready.

public/js/eco-scripts/abi_manager.js

public/js/eco-scripts/invoke_deploy_NeonJS.js

public/partials/ecolab.html

vncoelho · 2019-11-01T14:29:29Z

@corollari, I do not know why, but here in our repo I do not see how to update your PR based on master.

Do you know how to fix that?

vncoelho · 2019-11-01T15:17:47Z

"ERROR (DEPLOY): Only MainNet and TestNet are supported by wallet providers."

I tried on testnet but it says:
"Error: Connection destroyed
at neologin.js:8
at neologin.js:8
at Array.forEach ()
at destroy (neologin.js:8)
at neologin.js:8"

@corollari, it would be nice if the wallet of NEOLOGIN was added to the http://localhost:8000/#!/ecolab/wallet tab. Thus, the user can easily the balance it has.

public/js/eco-scripts/invoke_deploy_NeonJS.js

vncoelho · 2019-11-01T15:20:18Z

During deploy:

    Uncaught (in promise) ReferenceError: idToDeploy is not defined
    at handleDeploy (invoke_deploy_NeonJS.js:297)
    at invoke_deploy_NeonJS.js:284"

corollari · 2019-11-01T16:22:00Z

No idea how to fix the thing with github but I just rebased the PR on master, that should have the same effect.

vncoelho · 2019-11-01T16:27:02Z

Perfect, I had mad a PR on your repo for such update. But the rebase may had solved that.

vncoelho · 2019-11-01T16:28:13Z

public/partials/ecolab.html

@@ -3052,4 +3083,6 @@ <h4>ABI:</h4>
      sendingTxPromiseWithEcoRaw(PendingTX,PendingTXParams);
    }
    </script>
+	<script src="https://cdn.jsdelivr.net/npm/neo-dapi@1.0.2/lib/neo-dapi.min.js"></script>


before merging we should download these .js and load from the file.
We are doing that with all packages of neocompiler in order to avoid dependencies with external providers.

Done! I've also added instructions on how to download these packages (especially important in the case of O3 because versions of the js package which are newer than 1.0.2 do not work) to public/js/README.md

corollari · 2019-11-01T16:45:47Z

It seems github automatically marked your PR as merged

corollari · 2019-11-01T16:46:26Z

Working on solving the problems that you raised on deploy() currently

corollari · 2019-11-01T18:29:25Z

Just fixed the following error:

I tried on testnet but it says:
"Error: Connection destroyed
at neologin.js:8
at neologin.js:8
at Array.forEach ()
at destroy (neologin.js:8)
at neologin.js:8"

corollari · 2019-11-01T18:32:30Z

Will start working on adding addresses & balances to the wallet tab

corollari · 2019-11-02T17:11:17Z

Just fixed the bug that caused the following error you reported:

    Uncaught (in promise) ReferenceError: idToDeploy is not defined
    at handleDeploy (invoke_deploy_NeonJS.js:297)
    at invoke_deploy_NeonJS.js:284"

corollari · 2019-11-02T21:44:11Z

@corollari, it would be nice if the wallet of NEOLOGIN was added to the http://localhost:8000/#!/ecolab/wallet tab. Thus, the user can easily the balance it has.

Just pushed one last commit that makes the wallet provider's address appear in all the places where the set of pre-defined addresses of ECO_WALLET usually appear, including the /wallet tab. Thoughts?

public/partials/ecolab.html

vncoelho · 2019-11-04T16:50:22Z

@corollari, Alllbert, do you have O3 installed and running, right?

Take a look at this api: https://neodapitestbed.o3.app/index.html
When you change network and wallet on the O3 interface the address also changes on the front-end (their api was not complete, but I think it gives a good idea. Andreit sent it so me sometime ago). I believe that we can reach an even better level here on NeoCompiler.

For the neocompiler-eco we would need to update the ECO_WALLET' array.

public/partials/ecolab.html

vncoelho · 2019-11-06T21:11:45Z

@corollari, can you give me access to your branch?

vncoelho · 2019-11-06T21:22:56Z

@corollari, I changed the provider from "None" to "NeoCompiler-Eco".

We still need to update the other parts that use the flag "None"

corollari · 2019-11-07T12:39:28Z

@vncoelho When I created the PR I ticked the checkbox to give you access to the branch but maybe there's smth wrong, do you want me to port these commits into a branch of the neoresearch repo?

vncoelho · 2019-11-07T12:43:59Z

In fact, it is strange, I was able to commit, but not to merge the PR corollari#2.

I think it is ok, @corollari. I will work on the PR locally and try to push.

vncoelho · 2019-11-08T00:33:56Z

I have added the code to get the account on neocompiler-eco to change when it is changed in the wallet but I can't get it to work.

This should work.
Another good example would be the network.
If the network is changed in the wallet provider it should change on neocompiler as well.

corollari · 2019-11-10T20:45:33Z

Is there anything missing on my end? I'm not trying to put pressure but just to make sure that I haven't forgotten something due to the conversation being split between discord and github.

vncoelho · 2019-11-10T21:36:38Z

Noo, @corollari, you are doing great.
The delay in merging is my fault now. I am trying to give priority on this.

But we focused on removing all node requirements from the project. Now, everything is dockerized! This helped a lot.
Tomorrow I will surely try to run it.

public/js/eco-scripts/accounts.js

vncoelho · 2019-11-10T23:56:17Z

public/partials/ecolab.html

+		}
+		if($("#ecolabproviderselection").val() === "NeoCompiler-Eco"){
+			changeAccount(window.storedECO_WALLET);
+		} else {


It looks like this is not working. I do not know why but the EcoWallet is being kept as the original.

It was not working on Brave Browser!
On firefox it worked.

It is strange, @corollari, because https://neologin.io/testbed/#collapse-getProvider works on Brave.

That's really strange because I did all my development on Chromium.. did you manage to find the root cause?

neologin-1.2.4.js:8 Uncaught (in promise) Error: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. at main.17a8c4b5.chunk.js:1 at new Promise (<anonymous>) at X (main.17a8c4b5.chunk.js:1) at Object.keys.map._.<computed> [as getAccount] (main.17a8c4b5.chunk.js:1) at 2.6d2d096a.chunk.js:1 at new Promise (<anonymous>) at l (2.6d2d096a.chunk.js:1)

I think that the error is this one.
It keep Pending on GetAccount...I do not know. Strange.But on firefox it is ok.

public/partials/ecolab.html

vncoelho

I was able to test everything now, @corollari!!!
I think that we are almost there.

Pending things are:

Track the changes on EcoWallet on every step, thus, we do not lose them when we move to Provider and come back;
Enable transfers. Otherwise we can not claim GAS from the NeoCompiler-Eco Front-end.
Remove the checkProviderNetwork check, why we can not operate on PrivateNet or SharedPrivateNet? We just need NeoLogin capabilities for signing the txs, right?

I will also try to help on them tomorrow, perhaps I can tackle 1.

Mergin Master

corollari · 2019-11-11T13:25:59Z

On it!

…eoline

vncoelho · 2019-11-11T14:03:08Z

@corollari, great job, once more!
I think we can merge it. All standard functionalities look like to be working perfect!

vncoelho · 2019-11-14T04:40:52Z

@corollari , thanks for everything.

I did not double check, quite busy here with Wang Yong Qiang and some talks on some Universities here..ahauah Great time!
But we manage future feature and improvements on next PRs.

vncoelho marked this pull request as ready for review July 10, 2019 16:28

vncoelho reviewed Jul 10, 2019

View reviewed changes

public/js/eco-scripts/invoke_deploy_NeonJS.js Outdated Show resolved Hide resolved

public/js/eco-scripts/invoke_deploy_NeonJS.js Outdated Show resolved Hide resolved

public/partials/ecolab.html Outdated Show resolved Hide resolved

corollari changed the title ~~[WIP] Integrate NEOLine~~ Integrate wallet providers Oct 13, 2019

vncoelho reviewed Oct 30, 2019

View reviewed changes

public/js/eco-scripts/abi_manager.js Outdated Show resolved Hide resolved

public/js/eco-scripts/invoke_deploy_NeonJS.js Outdated Show resolved Hide resolved

public/partials/ecolab.html Show resolved Hide resolved

public/partials/ecolab.html Show resolved Hide resolved

vncoelho reviewed Nov 1, 2019

View reviewed changes

public/js/eco-scripts/invoke_deploy_NeonJS.js Outdated Show resolved Hide resolved

corollari force-pushed the neoline branch from 95c7c70 to 24cc7cc Compare November 1, 2019 16:22

vncoelho reviewed Nov 1, 2019

View reviewed changes

corollari force-pushed the neoline branch from ae05699 to 9414251 Compare November 2, 2019 14:30

vncoelho reviewed Nov 4, 2019

View reviewed changes

public/partials/ecolab.html Outdated Show resolved Hide resolved

vncoelho reviewed Nov 4, 2019

View reviewed changes

public/partials/ecolab.html Outdated Show resolved Hide resolved

move o3 script to index

37b8930

vncoelho reviewed Nov 10, 2019

View reviewed changes

public/js/eco-scripts/accounts.js Show resolved Hide resolved

vncoelho reviewed Nov 10, 2019

View reviewed changes

vncoelho reviewed Nov 11, 2019

View reviewed changes

public/partials/ecolab.html Outdated Show resolved Hide resolved

vncoelho reviewed Nov 11, 2019

View reviewed changes

vncoelho added 9 commits November 11, 2019 13:02

Fixing log of watchonly RPC node

0d45b01

Trying to fix neoscan syncing with only one node

6b626bc

Fixing wrong url for neoscan and cleaning

79ad982

Adding necessary file to ecoservices express

b1d8547

Untracking the file of services express

b39a5b6

Minor change on log

bad3378

Adding bracket for allowing reading json

72110c0

Updating metadata file template accordingly

76536a5

Remove comments for base paths

a04af31

vncoelho changed the base branch from master to neocompiler-eco-neo3-preview November 11, 2019 13:24

vncoelho changed the base branch from neocompiler-eco-neo3-preview to master November 11, 2019 13:24

Merge pull request #4 from NeoResearch/master

d4ad9fa

Mergin Master

vncoelho added 6 commits November 11, 2019 10:36

Keep Cache of Wallet updated

aaa4d37

Merge branch 'neoline' of github.com:corollari/neocompiler-eco into n…

7e58019

…eoline

Updating all date of wallets

6fc1a18

Adding flag for avoiding saving wallet in some cases

558e35d

Adding description to provider

d92d9e0

Avoiding GenesisBlock errors

5a310c7

vncoelho merged commit 5b30afd into NeoResearch:master Nov 14, 2019

Integrate wallet providers #65

Integrate wallet providers #65

Conversation

corollari commented Jul 10, 2019

vncoelho commented Jul 10, 2019 • edited Loading

vncoelho commented Jul 10, 2019

corollari commented Oct 13, 2019

corollari commented Oct 27, 2019

vncoelho left a comment

Choose a reason for hiding this comment

vncoelho commented Nov 1, 2019

vncoelho commented Nov 1, 2019

vncoelho commented Nov 1, 2019 • edited Loading

corollari commented Nov 1, 2019

vncoelho commented Nov 1, 2019

vncoelho Nov 1, 2019

Choose a reason for hiding this comment

corollari Nov 2, 2019

Choose a reason for hiding this comment

corollari commented Nov 1, 2019

corollari commented Nov 1, 2019

corollari commented Nov 1, 2019

corollari commented Nov 1, 2019 • edited Loading

corollari commented Nov 2, 2019

corollari commented Nov 2, 2019

vncoelho commented Nov 4, 2019 • edited Loading

vncoelho commented Nov 6, 2019

vncoelho commented Nov 6, 2019

corollari commented Nov 7, 2019 • edited Loading

vncoelho commented Nov 7, 2019

vncoelho commented Nov 8, 2019

corollari commented Nov 10, 2019

vncoelho commented Nov 10, 2019

vncoelho Nov 10, 2019

Choose a reason for hiding this comment

vncoelho Nov 11, 2019

Choose a reason for hiding this comment

vncoelho Nov 11, 2019

Choose a reason for hiding this comment

corollari Nov 11, 2019

Choose a reason for hiding this comment

vncoelho Nov 11, 2019

Choose a reason for hiding this comment

vncoelho left a comment • edited Loading

Choose a reason for hiding this comment

corollari commented Nov 11, 2019

vncoelho commented Nov 11, 2019

vncoelho commented Nov 14, 2019 • edited Loading

vncoelho commented Jul 10, 2019 •

edited

Loading

vncoelho commented Nov 1, 2019 •

edited

Loading

corollari commented Nov 1, 2019 •

edited

Loading

vncoelho commented Nov 4, 2019 •

edited

Loading

corollari commented Nov 7, 2019 •

edited

Loading

vncoelho left a comment •

edited

Loading

vncoelho commented Nov 14, 2019 •

edited

Loading