Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rest-client with http.rb #68

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

oskaror
Copy link
Contributor

@oskaror oskaror commented Feb 2, 2022

Fix #21
Currently, we use the rest-client gem, but it's a very heavy-weight library, so I replaced it with http.rb


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.

@Neodelf
Copy link
Owner

Neodelf commented Feb 2, 2022

I am checking what's going on

@Neodelf
Copy link
Owner

Neodelf commented Feb 2, 2022

@oskaror I didn't greet you. I am so sorry. I really tried to fast solve the problem 💨
Thank you for your updates! I really appreciate it! ❤️
So I set the simplecov gem version directly. Please, rebase the branch from master. Hope it helps.
Also, please update CHANGELOG.md

@Neodelf Neodelf merged commit d8b3697 into Neodelf:master Feb 3, 2022
@Neodelf
Copy link
Owner

Neodelf commented Feb 3, 2022

Thank you for your work!

@Neodelf
Copy link
Owner

Neodelf commented Feb 3, 2022

@all-contributors please add @oskaror for code

@allcontributors
Copy link
Contributor

@Neodelf

I've put up a pull request to add @oskaror! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace rest-client with smth
2 participants