Added support for git stash list
#1280
Conversation
- Linking the components together - Adding options - Building a buffer for viewing stashes.
All the pieces are wired up, all that's left is to implement everything correctly.
`M:open` lets me use `self.foo` inside the function.
Added proper structure for UI elements. But, no output on the newly created tab.
AlphabetsAlphabets
force-pushed
the
fork-master
branch
from
cc36f03
to
4098f2e
Compare
| self:close() | ||
| end, | ||
| ["<enter>"] = function() | ||
| -- Still looking for how to view a stash |
There was a problem hiding this comment.
You can use
neogit/lua/neogit/lib/git/rev_parse.lua
Line 23 in f10084a
git rev-parse 'stash@{0}') to get the OID from a stash, which can be passed into the buffer constructor.
| @@ -219,7 +219,7 @@ M.CommitEntry = Component.new(function(commit, args) | |||
| }, graph, { text(" ") }, ref, { text(commit.subject) }), | |||
| { | |||
| virtual_text = { | |||
| { " ", "Constant" }, | |||
| { " ", "Constant" }, | |||
There was a problem hiding this comment.
| { " ", "Constant" }, | |
| { " ", "Constant" }, |
lua/neogit/lib/git/stash.lua
Outdated
| rel_date = cli.log | ||
| .max_count(1) | ||
| .format("%cr") | ||
| .args("stash@{" .. idx .. "}") |
There was a problem hiding this comment.
| .args("stash@{" .. idx .. "}") | |
| .args(("stash@{%s}"):format(idx)) |
Not a major thing, but in lua strings are interned, so concatenation operations will re-hash the new string, for every .. operator.
In this case that would be something like:
hash("stash@{")
hash("stash@{1")
hash("stash@{1}")
Many successive re-hashings will have a noticeable performance hit. While it's probable that this list will never be long enough to encounter that, I just prefer to do string formatting or table.concat() to join strings :)
|
Nice work! Left some feedback |
`get_commit_under_cursor` to malfunction.
|
Hey, @CKolkey I fixed all the issues you brought up in the review. I also merged the latest from |
|
@CKolkey hey there. Would you mind taking a look at the changes? |
|
It's pretty good - there are still a handful of comments I left that are unresolved though. Take care of those and we'll merge this :) |
|
Hey - is there any movement on this? @AlphabetsAlphabets if you're no longer working on this feature, you mind if I fork off of you and fix the mentioned comments? |
|
Hi, feel free to do so. I'm very busy right now. |
Added basic support for
git stash list. Current functionality in the:Neogitscreen.Zthenlwill give a list of stashes.ENTERon any of the stashes will bring up a diff for that stash.