Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips besides RawDataToolTip have a hard time with events, (ToolMultiplexer, anything IToolTip Based) #2026

Closed
TehTurk opened this issue Apr 15, 2021 · 3 comments
Assignees
Labels
Enhancement New feature or request LogiX Neos Nodes, Behaviors, and Scripting Tools Relating to Tooltips and CommonTool

Comments

@TehTurk
Copy link
Collaborator

TehTurk commented Apr 15, 2021

Is your feature request related to a problem? Please describe.

Currently most tooltips don't have something akin to RawDataToolTip Events, where in issues #1468 there is a request for dequip/equip nodes while in issues #2024 it's similar but applies to Multiplexer directly.

Relevant issues

#1388 #1164 #1157 #1468

Describe the solution you'd like

If possible 2 options could happen,

We just have individual events for IToolTip such as De/Equip

  • OR -

Something of an overload or a new node akin to RawDataToolTip Events or something similar where it can take in any IToolTip and Reference into the proper node for what a tooltip might have associated with it. (A ToolTip Events Node)

Describe alternatives you've considered

Looking back from my experience trying to do something manual with a Standard Controller has proven to had it's benefits but also has it's issues at times when some events are not tied directly to a pulse.

Additional context

This was made after seeing both issues #1468 and #2024 and realize they were similar in nature and could be compounded.

@TehTurk TehTurk added Enhancement New feature or request Tools Relating to Tooltips and CommonTool labels Apr 15, 2021
@3x1t-5tyl3
Copy link

3x1t-5tyl3 commented Apr 15, 2021

I would like to mention this would go beyond just "Equipping" functions. But extend to ToolUpdates, secondary, primary ect. The same outputs the RawDataTooltip has.

@ProbablePrime ProbablePrime added the LogiX Neos Nodes, Behaviors, and Scripting label Apr 23, 2021
@ProbablePrime ProbablePrime self-assigned this Aug 13, 2021
@Frooxius
Copy link
Collaborator

We can add Equip/Dequip events as those are general, but updating of the tool, secondary and primary cannot be accessible, as those are processed by arbitrary logic of the tooltip, which can differ wildly between each one of them.

RawDataTooltip is designed to specifically forward these raw data, but most other tooltips are not, as we can't make assumptions about what they will be doing based on those actions. Instead we can offer ways to expose specific functionality to those particular tooltips based on what's needed and what they do, so it fits into their functionality well, but that would require us knowing more about your usecases.

@Frooxius
Copy link
Collaborator

Frooxius commented Sep 1, 2021

This has been implemented by ProbablePrime in 2021.9.1.643! Thanks for the request!

@Frooxius Frooxius closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request LogiX Neos Nodes, Behaviors, and Scripting Tools Relating to Tooltips and CommonTool
Projects
None yet
Development

No branches or pull requests

4 participants