Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost Uplink, ghost beacons closer to og #500

Merged

Conversation

AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Jul 11, 2024

Description

Adds the ghost uplink hud element to the bottom of the screen, modified ghost beacons to be closer to the original

Toolchain

  • Windows MSVC VS2022

Linked Issues

…ed ghost beacons to be closer to the original
@AdamTadeusz AdamTadeusz requested a review from a team July 11, 2024 20:06
@AdamTadeusz
Copy link
Contributor Author

AdamTadeusz commented Jul 11, 2024

I thought having the distance to the player on the bottom of the ghost marker looks much better than to the side so didn't change it

@Agiel
Copy link
Contributor

Agiel commented Jul 11, 2024

Could you post some screenshots to compare?

@AdamTadeusz
Copy link
Contributor Author

AdamTadeusz commented Jul 11, 2024

Heres a video of the new hud element overlayed onto a recording of the original at host_timescale 0.1

untitled.mp4

It's not aligned perfectly but you get the gist

mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.h Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.h Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.h Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.h Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.h Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.cpp Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.cpp Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_uplink_state.cpp Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_beacons.h Outdated Show resolved Hide resolved
mp/src/game/client/neo/ui/neo_hud_ghost_beacons.cpp Outdated Show resolved Hide resolved
nullsystem
nullsystem previously approved these changes Jul 15, 2024
Copy link
Collaborator

@nullsystem nullsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplink and updated beacon visuals looks good. Tested with master merged in.
2024-07-15T175515_screen

@Rainyan
Copy link
Collaborator

Rainyan commented Jul 17, 2024

Also, graphing the hardcoded index values, I'd suspect there's some kind of modified sine wave happening here, where half the period is 1 second long and the whole sequence is 15 seconds. But hardcoding the values seems acceptable for reproducing the original effect.

Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AdamTadeusz AdamTadeusz merged commit 1d4dd35 into NeotokyoRebuild:master Jul 19, 2024
5 checks passed
@AdamTadeusz AdamTadeusz deleted the 010_ghostPlayerMarkers branch August 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants