Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: CNEOHud_GhostMarker should internally work out ghost states #475

Open
nullsystem opened this issue Jul 3, 2024 · 0 comments · May be fixed by #476
Open

Refactor: CNEOHud_GhostMarker should internally work out ghost states #475

nullsystem opened this issue Jul 3, 2024 · 0 comments · May be fixed by #476
Assignees
@nullsystem
Labels
refactor Code refactor

Comments

@nullsystem
Copy link
Collaborator

nullsystem commented Jul 3, 2024 •
edited
Loading

Currently some setters set by a C_NEO_player to pass on ghosting team, client's states, etc.. but it can be done within CNEOHud_GhostMarker instead. Mostly less possible state issues.
@nullsystem nullsystem added the refactor Code refactor label Jul 3, 2024
@nullsystem nullsystem self-assigned this Jul 3, 2024
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 4, 2024
@nullsystem
Ghost - Refactor away from player to HUD/Gamerule
cea94cd 
* No longer handles states from player to HUD
* HUD handles some states itself, some given to gamerules to handle it
  instead especially for networked
* PVS over networked for smoother ghost visuals
* fixes NeotokyoRebuild#475
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 4, 2024
@nullsystem
Ghost - Refactor away from player to HUD/Gamerule
4f56b40 
* No longer handles states from player to HUD
* HUD handles some states itself, some given to gamerules to handle it
  instead especially for networked
* PVS over networked for smoother ghost visuals
* fixes NeotokyoRebuild#475
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 4, 2024
@nullsystem
Ghost - Refactor away from player to HUD/Gamerule
0bc917a 
* No longer handles states from player to HUD
* HUD handles some states itself, some given to gamerules to handle it
  instead especially for networked
* PVS over networked for smoother ghost visuals
* fixes NeotokyoRebuild#475
@nullsystem nullsystem linked a pull request Jul 4, 2024 that will close this issue
Open
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 6, 2024
@nullsystem
Ghost - Refactor away from player to HUD/Gamerule
5ba47a0 
* No longer handles states from player to HUD
* HUD handles some states itself, some given to gamerules to handle it
  instead especially for networked
* PVS over networked for smoother ghost visuals
* fixes NeotokyoRebuild#475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullsystem nullsystem

Labels
refactor Code refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ghost - Refactor away from player to HUD/Gamerule nullsystem/neo
1 participant
@nullsystem