Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost - Refactor away from player to HUD/Gamerule #476

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 4, 2024

Description

  • No longer handles states from player to HUD
  • HUD handles some states itself, some given to gamerules to handle it instead especially for networked
  • PVS over networked for smoother ghost visuals

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

* No longer handles states from player to HUD
* HUD handles some states itself, some given to gamerules to handle it
  instead especially for networked
* PVS over networked for smoother ghost visuals
* fixes NeotokyoRebuild#475
@nullsystem nullsystem changed the title [WAITING OTHER PR] Ghost - Refactor away from player to HUD/Gamerule Ghost - Refactor away from player to HUD/Gamerule Jul 6, 2024
@nullsystem nullsystem marked this pull request as ready for review July 6, 2024 13:09
@nullsystem nullsystem requested a review from a team July 6, 2024 13:09
@nullsystem nullsystem added the refactor Code refactor label Jul 6, 2024
@AdamTadeusz
Copy link
Contributor

Ghost is buttery smooth when in pvs, looks great. Would it be worth using the same text fadeout distance value for the ghost marker as for the capture zone marker?

@nullsystem
Copy link
Collaborator Author

@AdamTadeusz I've now put that in as its own convar, but same default as the cap zone's default.

@nullsystem nullsystem marked this pull request as draft July 14, 2024 21:47
@nullsystem nullsystem marked this pull request as ready for review July 14, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: CNEOHud_GhostMarker should internally work out ghost states
2 participants