Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Hash/version check for clients before joining server #485

Closed
kassibuss opened this issue Jul 6, 2024 · 0 comments · Fixed by #496
Closed

[FEATURE] Hash/version check for clients before joining server #485

kassibuss opened this issue Jul 6, 2024 · 0 comments · Fixed by #496
Assignees
@nullsystem
Labels
enhancement New feature or request

Comments

@kassibuss
Copy link
Contributor

Description

In previous playtests, people have joined with outdated builds, which has caused people to not have 1:1 experiences with others. It has also led to reporting outdated bugs, which have already been fixed

Proposed Solution

Add a check for the client before it joins a server so that the players cant connect with an outdated version of the game

Alternatives Considered

No response

Additional Context

No response
@kassibuss kassibuss added the enhancement New feature or request label Jul 6, 2024
@nullsystem nullsystem self-assigned this Jul 6, 2024
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 7, 2024
@nullsystem
Build integrity + server print neo_version info
e266b6d 
* Server now just prints neo_version on startup
* Server and client long git hashes are now matched up on startup to
  check build integrity. If they don't, the client cannot connect unless
  they have matching git hashes.
* Server convar `neo_sv_build_integrity_check` to enable/disable this
  integrity check feature. Enabled by default.
* fixes NeotokyoRebuild#437
* fixes NeotokyoRebuild#485
@nullsystem nullsystem mentioned this issue Jul 7, 2024
Merged
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 14, 2024
@nullsystem
Build integrity + server print neo_version info
303a61a 
* Server now just prints neo_version on startup
* Server and client long git hashes are now matched up on startup to
  check build integrity. If they don't, the client cannot connect unless
  they have matching git hashes.
* Server convar `neo_sv_build_integrity_check` to enable/disable this
  integrity check feature. Enabled by default.

Debug builds integrity check bypass
* Debug builds will have their first byte final bit fliped to 1 to
  indicate it's a debug build
* This will indicate to the server that it's a debug build and if
  the server allows bypass, then it will
* Mask out final bit before comparison to allow debug build that
  matches hash without first byte final bit

* fixes NeotokyoRebuild#437
* fixes NeotokyoRebuild#485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullsystem nullsystem

Labels
enhancement New feature or request
Projects
Bug Bounty
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Client vs server build integrity check + server startup print neo_version info nullsystem/neo
2 participants
@nullsystem @kassibuss