Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team chooser menu popping up when other player on PVS #510

Closed
1 of 2 tasks
nullsystem opened this issue Jul 14, 2024 · 0 comments · Fixed by #511
Closed
1 of 2 tasks

Team chooser menu popping up when other player on PVS #510

nullsystem opened this issue Jul 14, 2024 · 0 comments · Fixed by #511
Assignees
Labels
Bug Report Bug Reports made through the "Report Issue" interface in GitHub.

Comments

@nullsystem
Copy link
Collaborator

nullsystem commented Jul 14, 2024

Build Info

8621b06

Description

The C_Neo_Player::spawn function gets called everytime a player that haven't been seen before is in PVS. So effectively if not checked against if local player, this will pops up the team chooser menu as that's always shown in this point.

To Reproduce

  1. Create server -> Spawn in
  2. Then spawn some bots, at least 3 bots: sv_cheats 1; bot_add; bot_add; bot_add;
  3. Then go near each bots

Expected behavior

There shouldn't be the team chooser menu popup when you're near another player

Actual behavior

The team chooser menu pops up when you're near team/in PVS

Operating System

  • Windows
  • Linux

Version/Distro

Arch

Machine's CPU

No response

Machine's GPU

No response

GPU's driver

No response

Build's compiler

No response

Additional context and Screenshots

No response

@nullsystem nullsystem added the Bug Report Bug Reports made through the "Report Issue" interface in GitHub. label Jul 14, 2024
@nullsystem nullsystem self-assigned this Jul 14, 2024
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 14, 2024
* `C_NEO_Player::Spawn` is called not only for the local client's
  player, but also for other player (bot or actual) when they're in the
  local client's PVS
* If it's called, then only update the VGUIs if it's either local player
  wasn't set (so it's initially just spawned in) or matches the set local
  player's pointer.
* fixes NeotokyoRebuild#510
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 14, 2024
* `C_NEO_Player::Spawn` is called not only for the local client's
  player, but also for other player (bot or actual) when they're in the
  local client's PVS
* If it's called, then only update the VGUIs if it's either local player
  wasn't set (so it's initially just spawned in) or matches the set local
  player's pointer.
* fixes NeotokyoRebuild#510
@nullsystem nullsystem modified the milestones: v7, Parity Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Bug Reports made through the "Report Issue" interface in GitHub.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant