Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knife - Refactor to use CNEOBaseCombatWeapon, use sprint animation when sprinting #317

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Knife - Refactor to use CNEOBaseCombatWeapon, use sprint animation when sprinting #317

merged 5 commits into from
Jun 1, 2024

Conversation

nullsystem
Copy link
Collaborator

  • Refactored the knife to use CNEOBaseCombatWeapon as its based class, pulled over some melee specific stuff over
  • Refactored on functions that differentiates the knife when it wasn't a Neo-weapon
  • When sprinting, use the sprint animation. Fixes Sprinting with knife has a sprinting animation cycle #302

@nullsystem nullsystem added refactor Code refactor Gunplay Gunplay elements in Neotokyo. Grenades, TTK, etc. Animations Animation stuff. Including the syncronizing of animations between client and server based on state. labels May 31, 2024
@nullsystem nullsystem added this to the Parity milestone May 31, 2024
@nullsystem nullsystem requested a review from a team May 31, 2024 22:02
Agiel
Agiel approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@Agiel Agiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should move the damage to the script in the future.

@nullsystem nullsystem merged commit 346fc3b into NeotokyoRebuild:master Jun 1, 2024
Rainyan pushed a commit that referenced this pull request Jul 1, 2024
@nullsystem
Knife - Refactor to use CNEOBaseCombatWeapon, use sprint animation wh…
94a2354 
…en sprinting (#317)

* Refactor the knife to use NEOWeapon + run viewmodel
* Refactor around functionalities that uses the knife
* removed unnecessary stuff
* refactored the class a bit
* this isn't C99 so the void isn't necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agiel Agiel Agiel approved these changes

Assignees
No one assigned
Labels
Animations Animation stuff. Including the syncronizing of animations between client and server based on state. Gunplay Gunplay elements in Neotokyo. Grenades, TTK, etc. refactor Code refactor
Projects
Bug Bounty
Status: Done
Milestone
Parity
Development

Successfully merging this pull request may close these issues.

Sprinting with knife has a sprinting animation cycle
2 participants
@nullsystem @Agiel