Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit crash around m_pGameEvent in gHud situation #326

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jun 2, 2024

  • Just let neo_hud_elements handle it like the rest of the stuff there

@nullsystem nullsystem added the bug Something isn't working label Jun 2, 2024
@nullsystem nullsystem marked this pull request as draft June 2, 2024 17:20
@nullsystem nullsystem changed the title Don't put m_pGameEvent into gHud as this will crash on exit Fix exit crash around m_pGameEvent in gHud situation Jun 2, 2024
@nullsystem nullsystem marked this pull request as ready for review June 2, 2024 17:54
mp/src/game/client/hud.cpp Outdated Show resolved Hide resolved
* Instead use rain's suggestion to change it to using
  `DECLARE_HUDELEMENT` directly
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@nullsystem nullsystem merged commit c47dcc7 into NeotokyoRebuild:master Jun 3, 2024
Rainyan pushed a commit that referenced this pull request Jul 1, 2024
* Instead use rain's suggestion to change it to using
  `DECLARE_HUDELEMENT` directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants