Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the bug report template #409

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Update the bug report template #409

merged 6 commits into from
Jul 1, 2024

Conversation

blaberry
Copy link
Collaborator

rephrased some stuff and changed the label used for reports to an original one.

Description

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

  • fixes #
  • related #

rephrased some stuff and changed the label used for reports to an original one.
Change instructions to ask for current description of the world, rather than the ideal state as per offline discussion
should/shouldn't we use this style? we should.
@nullsystem
Copy link
Collaborator

nullsystem commented Jun 28, 2024

I still object with the requirement of "desired state" in a bug report title. From the perspective of an outsider who just comes here and files a bug report, it's typical for the title to be written as a "the current state" like how other projects allows/typical done (can just pick out chromium, firefox, etc...) and this "Make sure..." text could even easily be glossed over.
While the original intention was because the "desired state without should/shouldn't" it was before was confusing for bug fixing and hence requirement of "the current state" was put in, I think it'll just better to either omit title requirement and let bug reporters naturally fill in bug titles, or have a guideline for both style of title, not one.

Rainyan
Rainyan previously approved these changes Jun 28, 2024
@blaberry
Copy link
Collaborator Author

I'm not sure I understand the second approach you recommend, does "use either should or should not phrasing" not fulfill "have a guideline for both style of title"? @nullsystem

@nullsystem
Copy link
Collaborator

nullsystem commented Jun 29, 2024

@blaberry It's about "desired" vs "current" state of title phrasing. "should/should not" is a single "desired" style phrasing.

@blaberry
Copy link
Collaborator Author

Right, then we run into the issue we discussed at length over chat, where some items are desired state, some are not, and the mishmash of both will most likely turn out much harder to read than what's on offer in this PR

@nullsystem
Copy link
Collaborator

nullsystem commented Jun 29, 2024

@blaberry There's an important distinction between a bug, change request (opinionated, current state isn't a bug), and feature request. There shouldn't be a blanket all of those have same "desired" state titles, and what the current template have currently also gives a clearer distinction with the "[BUG] " title prefix even. The "desired" state titles are natural gravitation for change/feature requests, but as I've put it, the "current" state titles are natural gravitation for bug reports. It's not really a case of random some are/some are not thing, it's that there are distinction that issues titles written for bugs are done differently to change/feature requests.

@blaberry
Copy link
Collaborator Author

Alright so two different topics:

using a tag in the title: labels in Github are meant to categorize issues for easier filtering and searching. "[BUG]" in the title achieves a similar purpose, but it clutters the title and reduces readability. I added a new label to make this clearer. We can also add a label for FRs.

title formatting: I'll revert the title format instructions to how it was before since we can't find consensus on this.

Replace them with describing what is wrong, instead of specifying what ought to be.
Copy link
Collaborator

@nullsystem nullsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with this template

title must be of type String and cannot be empty.

https://github.com/NeotokyoRebuild/neo/blob/8844696f3dcda86a6ecea68444d759511c8ccdcd/.github/ISSUE_TEMPLATE/bug_report.yml

Removal of [BUG] feels like less clear on separate of bugs vs others but just relying on the tag are ok.

@Rainyan Rainyan merged commit 5eb8830 into master Jul 1, 2024
@Rainyan Rainyan deleted the blaberry-patch-1 branch July 1, 2024 14:12
Rainyan pushed a commit that referenced this pull request Jul 1, 2024
* Update the bug report template

rephrased some stuff and changed the label used for reports to an original one.

* Update bug_report.yml

Change instructions to ask for current description of the world, rather than the ideal state as per offline discussion

* Imperative bug report template

should/shouldn't we use this style? we should.

* Remove imperative and should/shouldn't instructions

Replace them with describing what is wrong, instead of specifying what ought to be.

* Set non null placeholder title.

* Remove title, might fix submit without title issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants