Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix HUD - fix timer and fix hud name #439

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Partial fix HUD - fix timer and fix hud name #439

merged 1 commit into from
Jun 30, 2024

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jun 30, 2024 •
edited
Loading

Description

  • This is a partial fix PR not full as other places/PRs will be done to eventually piece up to fix HUDs eventually
  • The hud names are all wrong due to macro trip-ups, they're now renamed to the actual one
  • During client-side spawning, reset the timer to 0 and slightly tweak the conditionals so it works properly on next map again.
  • [BUG] Hud stuck at resolution change and map change #414 will be marked as related not fixed as this is a partial PR

Toolchain

  • Windows MSVC VS2022

Linked Issues

@nullsystem
Partial fix HUD, fix timer and fix hud name
7f5bf2a 
* The hud names are all wrong due to macro trip-ups, they're now renamed
  to the actual one
* During client-side spawning, reset the timer to 0 and slightly tweak
  the conditionals so it works properly on next map again.
@nullsystem nullsystem requested a review from a team June 30, 2024 11:28
@AdamTadeusz
Copy link
Contributor

image
On a listen server the score hud is still frozen before the round starts. It does fix itself once the game starts however

@nullsystem
Copy link
Collaborator Author

image On a listen server the score hud is still frozen before the round starts. It does fix itself once the game starts however

@AdamTadeusz I'm going to fully fix that as part of #406 . That's why I named this PR partial.

@nullsystem nullsystem merged commit b671a2f into NeotokyoRebuild:master Jun 30, 2024
Rainyan pushed a commit that referenced this pull request Jul 1, 2024
@nullsystem
Partial fix HUD, fix timer and fix hud name (#439)
d4b205d 
* The hud names are all wrong due to macro trip-ups, they're now renamed
  to the actual one
* During client-side spawning, reset the timer to 0 and slightly tweak
  the conditionals so it works properly on next map again.
@nullsystem nullsystem deleted the GH-Partial414_FixHudPartial branch July 1, 2024 16:54
@nullsystem nullsystem mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rainyan Rainyan Rainyan approved these changes

@AdamTadeusz AdamTadeusz AdamTadeusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nullsystem @AdamTadeusz @Rainyan