Skip to content

Commit

Permalink
Fixes following the R devel mailing list
Browse files Browse the repository at this point in the history
  • Loading branch information
sedv8808 committed Apr 18, 2023
1 parent e578610 commit eaaef81
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Authors@R:
URL: https://github.com/NeotomaDB/neotoma2
BugReports: https://github.com/NeotomaDB/neotoma2/issues
Description: Access and manipulation of data using the Neotoma Paleoecology Database.
<https://api.neotomadb.org/api-docs/>.
<https://api.neotomadb.org/api-docs/>.
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
Expand Down
31 changes: 30 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,33 @@ As for the `get_manual.Rd` function, there are no parameters that the user needs
specimens-sites-method.Rd: I believe the same as for
get_datasets.numeric.Rd. ☑ Done

Done as suggested
Done as suggested

-----

## Responses to remarks I received from 3rd submission

### 1

Check: DESCRIPTION meta-information, Result: NOTE
Malformed Description field: should contain one or more complete sentences.

So, I originally sent:
```
Description: Access and manipulate data from the Neotoma Paleoecology Database. <https://api.neotomadb.org/api-docs/>
```
because I was requested to add <https://..> referencing the "Neotoma Paleoecology Database".
With the Description above, I do not get any local errors when running the R CMD but for CRAN, I got the error that I was asked to correct.

After e-mailing the R-package-devel mailing list and providing them with my github link, I was advised to indent with 8 spaces on the second line and finish the line with a `.`

The Description field in the Description file now looks like:

```
Description: Access and manipulate data from the Neotoma Paleoecology Database.
<https://api.neotomadb.org/api-docs/>
```

There are no spaces after https:// and 8 indents have been added as requested.

I hope this is correct now, otherwise, please give me some more references/examples so that I can do it properly.

0 comments on commit eaaef81

Please sign in to comment.