Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global config feature #115

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Add global config feature #115

merged 1 commit into from
Dec 10, 2020

Conversation

stephanemartin
Copy link
Contributor

What?

Add config without login/logout life cylcle

Why?

To manage different settings from features.

How?

By add new command and librairies to writes and read files.

Copy link
Collaborator

@guillaumebert guillaumebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an error when the file is empty (I removed manually all values). Don't know if this is a bug or not:
AttributeError: 'NoneType' object has no attribute 'items'

The general readme will be updated when the first configuration will be available

neoload/commands/config.py Outdated Show resolved Hide resolved
@stephanemartin stephanemartin force-pushed the topic-config-global branch 2 times, most recently from 79c923d to 9968290 Compare December 9, 2020 17:04
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.5% 93.5% Coverage
0.0% 0.0% Duplication

@stephanemartin stephanemartin merged commit 14d1d38 into master Dec 10, 2020
@guillaumebert guillaumebert deleted the topic-config-global branch December 18, 2020 08:12
@paulsbruce paulsbruce added the enhancement New feature or request label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants