Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Issues with gitlab openshit CI examples #141

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

TanguyBaudrin
Copy link
Contributor

Example for gitlab CI with openshift is missing some commands, and can't be used directly.

This commits aims to fix it based on current implementation I've made on my side.

Example for gitlab CI with openshift is missing some commands, and can't be used directly.

This commits aims to fix it based on current implementation I've made on my side.
Copy link
Collaborator

@paulsbruce paulsbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in my local Gitlab and works; approved, and thank you for contributing! Looking forward to future work together with you.

@paulsbruce paulsbruce added bug Something isn't working documentation Improvements or additions to documentation labels Mar 26, 2021
@paulsbruce paulsbruce merged commit b5ce989 into Neotys-Labs:master Mar 26, 2021
@paulsbruce paulsbruce removed the bug Something isn't working label Mar 30, 2021
stephanemartin pushed a commit to stephanemartin/neoload-cli that referenced this pull request Apr 15, 2021
Example for gitlab CI with openshift is missing some commands, and can't be used directly.

This commits aims to fix it based on current implementation I've made on my side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants