Update fastfail and SLA report, warning are not failures #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanemartin
pushed a commit
to stephanemartin/neoload-cli
that referenced
this pull request
Apr 15, 2021
…#145) * Add debug outcomes logic * Fix fastfail command max 4hrs * Refactor max mins to wait for fastfail to separate function * Refactor max mins to wait for fastfail to separate function * Update fastfail loop to report only every 15s and filter to non-successes * Update fastfail sla grouping for displayer * Only report actual FAILURE during fastfail printouts * Switch from using HTML < br / > tags to \ n character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update fastfail logic so that it does not print all SLAs every 15s loop iteration. Also update SLA report output to not treat warnings on SLAs as test suite failures.
Why?
When using fastfail, WFM was experiencing superfluous console output (fastfail prints) and in pipelines were blocked when SLA warnings were being interpreted as failures.
How?
Update fastfail loop logic and displayer logic for junit output.
Testing
All tests passed locally, no need to write an extra test for SLA outputs.